[oneMKL samples][computed tomography] Revisions, refactoring and addition of a functional verification #2564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR revises the "computed tomography" oneAPI sample.
The sample itself was revised so that the application creates reconstructed signal/image samples that are real (no longer complex) and so that those generated real values are directly comparable to the input image's (gray-scale-converted) values themselves. These changes are motivated by the desire to introduce a legitimate functional validation step (introduced herein as well), but that need triggered more thorough revision(s) of the sample's source code.
Extensive explanatory comments were added to the source code, explaining the mathematical nature of the operations at play and/or the technical details related to the suggested implementation.
Type of change
How Has This Been Tested?
This was extensively tested on a PVC GPU (512 EUs) and a SPR CPU using a machine operating Ubuntu 22.04. The default input file as well as others (not added to this PR) were considered along with an extensive range of input parameters. Due to the nature of the operations at play, one simply cannot guarantee that the mean global error will be below the arbitrarily-chosen threshold for any input file and any choice of (supported) input parameters. However,
The updated sample's default behavior was also successfully tested on a BMG GPU machine operating Windows 11.
Regarding instructions to test or to run the sample with different inputs, please refer to the application's "Usage" information (printed in case of invalid usage).